Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge transformAssetUrls options #216

Merged
merged 1 commit into from
Jan 27, 2021
Merged

fix: merge transformAssetUrls options #216

merged 1 commit into from
Jan 27, 2021

Conversation

Seminioni
Copy link
Contributor

Hi guys.

I'm using vuetify via vue-cli-plugin-vuetify at work.

Yesterday I added @yzfe/svgicon plugin for using *svg as vue' component and noticed that usage over docs' example doesn't work (see https://mmf-fe.github.io/svgicon/en/guide/#usage). It simply didn't load svg over <icon data="@icon/arrow.svg" /> method.

<template>
    <div>
        <!-- It is assumed that the alias of the svg file path is configured: @icon  -->
        <icon data="@icon/arrow.svg" />
    </div>
</template>

@icon is configured alias at .vue-svgicon.config.js config of @yzfe/svgicon plugin.

I tried to install @yzfe/svgicon plugin in newly created vue project over vue create project-name and it worked. Then I installed vuetify over vue add vuetify command and icon plugin stoped working.

After some time spent for researching I discovered that yours vue-loader' config doesn't merge transformAssetUrls' settings but wiped assigned before setting of others plugins.

@KaelWD KaelWD changed the title fix: merge "transformAssetUrls" options fix: merge transformAssetUrls options Jan 27, 2021
@KaelWD KaelWD merged commit d829f25 into vuetifyjs:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants