fix: add support for sass-loader > 8.0.0 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Oct 21, 2019
| opt.data = data.join('\n') | ||
| let sassLoaderVersion | ||
| try { | ||
| sassLoaderVersion = semver.major(require('sass-loader/package.json').version) |
There was a problem hiding this comment.
sass-loader should be declared in peerDependencies
There was a problem hiding this comment.
To support Yarn PnP, but most importantly, to ensure the package manager is aware of it so it can place it in a location where vue-cli-plugin-vuetify can require it.
It can be marked as a optional peer dependency to avoid warnings
cc @arcanis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #119.
We should probably also install 8.0.0 in our generator (https://github.com/vuetifyjs/vue-cli-plugin-vuetify/blob/dev/generator/tools/alaCarte.js#L6)
Since @vue/cli now also installs 8.0.0 ever since
3.12.0and4.0.0-rc4