Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: My Account - broken order details product linking #768

Closed
1 task done
bartoszherba opened this issue Mar 22, 2022 · 4 comments
Closed
1 task done

[Bug]: My Account - broken order details product linking #768

bartoszherba opened this issue Mar 22, 2022 · 4 comments
Assignees
Labels
bug Something isn't working triage-needed Issues that need to be checked vsf_team
Milestone

Comments

@bartoszherba
Copy link
Collaborator

bartoszherba commented Mar 22, 2022

Expected Behavior

When I click on the product in the order's details, I should land on the selected product (unless it is no more available). On the other hand, as mentioned, the product might be not available anymore, in Luma there is no link in the order details. Therefore, maybe the expectation is to remove that link.

Actual Behavior

Currently, the link is broken and leads to 404.

Possible Solution

Either, make the link work if there is a product or remove it to align with luma functionality.

Steps to reproduce

  1. Log in as a customer
  2. Assuming that you have some orders, go to the orders tab in my account
  3. Select any order to see its details
  4. On the product list click one of the products
  5. Observe beautiful 404

What version of Magento 2 integration are you using?

2.4.x

What version of Node.js are you using?

16.13.1

What browser (and version) are you using?

Version 96.0.4664.110 (Official Build) (arm64)

What operating system (and version) are you using?

macOS Monterey 12.1

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bartoszherba bartoszherba added bug Something isn't working triage-needed Issues that need to be checked vsf_team labels Mar 22, 2022
@Frodigo Frodigo added this to the 1.0.0-rc.7 milestone Mar 22, 2022
@sync-by-unito sync-by-unito bot assigned Frodigo and bartoszherba and unassigned Frodigo Mar 23, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Mar 23, 2022

➤ Marcin Kwiatkowski commented:

I tested it and looks like everything works properly.

Bartosz Herba you saw 404 errors because the product you entered does not exist anymore in Magento.

I placed the new order and when I went to order details and click on the product, the link worked properly.

Let me know if you have any additional questions, my dear friend. If not, please just close this one.

Thanks,

Marcin

@sync-by-unito sync-by-unito bot assigned Frodigo and unassigned bartoszherba Mar 23, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Mar 23, 2022

➤ Marcin Kwiatkowski commented:

Bartosz Herba I checked again and looks like the issue exists, but only for configurable products.

Sorry for the confusion.

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 23, 2022

➤ Marcin Kwiatkowski commented:

Ready for CR: #778 ( https://github.com/vuestorefront/magento2/pull/778|smart-link )

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 23, 2022

@sync-by-unito sync-by-unito bot closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage-needed Issues that need to be checked vsf_team
Projects
None yet
Development

No branches or pull requests

2 participants