Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Hydration attribute mismatch with theme-default #282

Closed
Mister-Hope opened this issue Oct 25, 2024 · 6 comments
Closed

[Bug report] Hydration attribute mismatch with theme-default #282

Mister-Hope opened this issue Oct 25, 2024 · 6 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed package:theme-default

Comments

@Mister-Hope
Copy link
Member

Description

See console

Reproduction

https://ecosystem.vuejs.press/

Used Package Manager

pnpm

System Info

.
@Mister-Hope
Copy link
Member Author

@pengzhanbo Need some help here, I am not finding the reason myself

@pengzhanbo
Copy link
Member

<a aria-label="Theme Guidelines" class="route-link auto-link" href="/themes/guidelines"><!---->Theme Guidelines<!----></a>

  - rendered on server: href="/themes/guidelines"
  - expected on client: href="/themes/guidelines.html"
  Note: this mismatch is check-only. The DOM will not be rectified in production due to performance overhead.
  You should fix the source of the mismatch.

The <AutoLink> component has inconsistent results between SSR and client-side rendering when handling the href attribute.

@pengzhanbo
Copy link
Member

But when I built it locally and checked the SSR output, it turned out to be normal.

@Mister-Hope
Copy link
Member Author

Mister-Hope commented Oct 26, 2024

Yes, and that's why I am confusing.

The console warning seems to be another confusion, as such detailed msg should only be outputted with a VUE_XXX to be true, and that needs a --debug flag

@Mister-Hope Mister-Hope added the help wanted Extra attention is needed label Oct 26, 2024
@pengzhanbo
Copy link
Member

pengzhanbo commented Oct 28, 2024

I checked the build process in workflows/release.yml, and in jobs deploy-docs, it executes pnpm build instead of pnpm bundle. Is there a problem with that?

I also checked the output on the netlify branch. In the index.html of the branch, the build output is normal. However, the source code online is inconsistent with the branch source code.

@Mister-Hope
Copy link
Member Author

Fixed. Pretty URLs is default on for all Netlify sites, and should be manually toggled to 'off', a manually redeploy is needed to sync the configuration changes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed package:theme-default
Projects
None yet
Development

No branches or pull requests

2 participants