-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(MdDatepicker): Better flow #1698
refactor(MdDatepicker): Better flow #1698
Conversation
BREAKING CHANGE: upgrade date-fns to 2.0.0-alpha.7 fix #1689
@VdustR I think this is not good with the HTML5 standard unless we provide a "format" prop. To pass something like "dd/mm/yyyy". Do you think you can implement something like that? |
Do you mean another props |
I mean, we should document the locale.dateFormat. |
I added date format option into basic example. Additionally, I think there could be another page(or somewhere else) to explain all vue material options. How do you think? |
@VdustR I agree with you on that New Page thing. Do you think you can do that? It can be on a new page called "Configure" after the getting started. |
docs/app/pages/Configuration.vue
Outdated
<template> | ||
<page-container centered :title="$t('pages.configuration.title')"> | ||
<div class="page-container-section"> | ||
<h2 class="md-headline">How to customized</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe is better to be "Global configuration".
</code-example> | ||
<p>or you can change it via <code>this.$material</code> in a vue component:</p> | ||
<code-example :title="$t('pages.configuration.inVueComponents')"> | ||
export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can also be a table with the API. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. The configuration object is nested. I'm afraid that it can't be described its structure clearly with table.
date-fns
to2.0.0-alpha.7
For using new parser API because we have custom date string format
inputDate
(the string from input),localDate
andvalue
(fromv-model
)v-model
supportsnumber
andstring
now, and its type is reactively modifiable via changing the type ofv-model
or changing the new props:md-model-type
.Including documentation
BREAKING CHANGE: upgrade
date-fns
to2.0.0-alpha.7
fix #1689