Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): adding logger type for logger plugin #1853

Merged
merged 1 commit into from
Oct 23, 2020
Merged

feat(types): adding logger type for logger plugin #1853

merged 1 commit into from
Oct 23, 2020

Conversation

itomtom
Copy link
Contributor

@itomtom itomtom commented Oct 18, 2020

  • createLogger options takes in logger which by default is console but
    can be overridden with own logger.
  • Adding Ilogger for logger options params which expects log method to
    be implemented

kiaking
kiaking requested changes Oct 19, 2020
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR! yeah we totally forgot about logger option hah...

I've made a comment. Could you have a look 🙏 ?

types/logger.d.ts Outdated Show resolved Hide resolved
@kiaking kiaking added the types Related to typings only label Oct 19, 2020
feat(types): adding logger type for logger plugin
b974e01 
* createLogger options takes in logger which by default is console but
can be overridden with own logger.
* Adding Ilogger for logger options params which expects log method to
be implemented
@kiaking kiaking merged commit cb3198d into vuejs:dev Oct 23, 2020
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 2, 2024
Open
@JhayceFrancis JhayceFrancis mentioned this pull request Jul 17, 2024
Merged
This was referenced Jul 20, 2024
Open
Open
@wjygit0428 wjygit0428 mentioned this pull request Aug 10, 2024
Open
This was referenced Aug 20, 2024
Open
Open
@angeloreale angeloreale mentioned this pull request Aug 27, 2024
Open
@natbia natbia mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
types Related to typings only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itomtom @kiaking