Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn v2 compat: add vue to peerDependencies #1681

Closed
AlexandreBonaventure opened this issue Feb 12, 2020 · 2 comments
Closed

Yarn v2 compat: add vue to peerDependencies #1681

AlexandreBonaventure opened this issue Feb 12, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@AlexandreBonaventure
Copy link

Version

3.1.2

Steps to reproduce

When using Typescript, vuex export types like here: https://github.com/vuejs/vuex/blob/dev/types/index.d.ts#L1 But as you can see here, it imports Vue typings to make it work. As a matter of fact vue should be added to peerDependencies

What is expected?

vue should be a peerDependency

What is actually happening?

it is not, and it fails in a strict dependency-tree context

Ref: vuejs/vue-cli#5135

@kiaking
Copy link
Member

kiaking commented Mar 9, 2020

Thanks for the report! Yap, indeed we should have it as a peer dependency. PR on the way 👍

@kiaking kiaking added the enhancement New feature or request label Mar 9, 2020
@kiaking kiaking self-assigned this Mar 9, 2020
@kiaking
Copy link
Member

kiaking commented Mar 9, 2020

And this is fixed at Vuex 3.1.3 🎉
https://github.com/vuejs/vuex/releases/tag/v3.1.3

@kiaking kiaking closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants