Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip HTML from the left in headers extraction #693

Closed
roberthamel opened this issue Aug 1, 2018 · 0 comments · Fixed by #711
Closed

Strip HTML from the left in headers extraction #693

roberthamel opened this issue Aug 1, 2018 · 0 comments · Fixed by #711
Labels
type: feature request Request to add a new feature

Comments

@roberthamel
Copy link

Feature request

What problem does this feature solve?

  • Add the ability to strip markup from a page header at compile time.
  • Include a scenario where markup wrapped within inline code identifier can be considered header content.

What does the proposed API look like?

Make the following assertions pass:

expect(deeplyParseHeaders('# <Comp/> *H1* ')).toBe('# H1')
expect(deeplyParseHeaders('# `<Comp/>` `H1`')).toBe('# <code><Comp></code> H1')

How should this be implemented in your opinion?

Filter the page title before being injected into the page head (or sidebar?)

Are you willing to work on this yourself?**

Certainly

@ulivz ulivz closed this as completed in #711 Aug 8, 2018
@ulivz ulivz added the type: feature request Request to add a new feature label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request Request to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants