Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar Link highlighting issue with multilanguage configuration #445

Closed
Carnageous opened this issue May 14, 2018 · 3 comments
Closed

Navbar Link highlighting issue with multilanguage configuration #445

Carnageous opened this issue May 14, 2018 · 3 comments

Comments

@Carnageous
Copy link

  • Your OS: Windows 7
  • Node.js version: v9.7.0
  • VuePress version: v0.8.4
  • Browser version: Chrome 66 (Doesn't work in IE or Firefox either.)
  • Is this a global or local install? Global
  • Which package manager did you use for the install? npm 6.0.1

I recently internationalized my vuepress site and noticed that the Nav links where underlined incorrectly in the new added language (german). Not only the selected Page was underlined, but also the Start button (as seen in the screenshot below. This is the case in Chrome, Firefox and IE, I inspected the DOM and noticed that the nav-link router-link-active class simply was not removed from the link when clicking on another one. However, this is only the case in the German version of the page, the English version with the same file structure and configuration works just fine.

Screenshot of the german version:
vuepress

Here a gist of my config file: https://gist.github.com/iCarnagy/4d0995c33a37d2ca845c2c3161f3978d

@ulivz
Copy link
Member

ulivz commented May 14, 2018

Could you provide the reproduction repo instead of only config?

@Carnageous
Copy link
Author

@ulivz Sorry, I uploaded the files to this repo: https://github.com/iCarnagy/vuepress-multilang-issue

@ulivz ulivz closed this as completed in 596014f May 15, 2018
@ulivz
Copy link
Member

ulivz commented May 15, 2018

This issue is because we only apply exact match mode for the root path "/".

Fixed at 596014f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants