-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] The file path & route of default language and others should be flat #363
Comments
I start to realise the issue that you are experiencing. I have looked into it and looks like it will require some major refactoring. @ulivz do you think we should facilitate this? |
Or, if #290 (comment) is not a bug, is there any ways to disable the language selector in specified pages? |
We don't plan to change the implementation for i18n, but this feature can be done via For now, you can test this by these steps
{
path: "/",
redirect: "/en/"
},
|
It's OK. |
Perhaps this feature request could be restated as: "Allow user to have a flat file structure for multiple languages by giving them the option to pass in redirect path" Config
ExpectedDocs would need to be updated with description of config switch: used to redirect traffic coming from the root path to another directory. Useful if you would rather have a flat folder structure for all of your languages, i.e.
instead of
The blank README.md at the root directory should be autogenerated if it isn't present - this way users need only add the config option. Not sure what to do in case one is present? Could offer a warning that the readme there is for redirection If you like this idea, re-open this issue and I'll make a PR 😸 |
@Dafrok what do you think of the above suggestion? |
@GrayedFox LGTM |
Ahoy, I am still planning on implementing this - first attempt (at getting it to be done during the build process) was unsuccessful - so I next attempt will be to take a more bootleg approach and try to update the |
Since the existing i18n model has taken root, now, and for the foreseeable future, we are not going to modify the default i18n mode. Of course, if you are passionate about your own model, consider using the plugin API to custom this during build time. |
This is really needed for those who want to automate the translation/localization in orgs. As an example: https://docs.transifex.com/transifex-github-integrations/github-tx-ui#linking-a-specific-project-with-a-github-repository Transifex uses a pattern of Although I can set a filter pattern for the target language, since This is an example of the
If we have a structure like shit:
Not only |
Version
^0.7.1
Description
I think this feature is necessary. It makes finding files easier ,the management of files clearer, and developers can simply customize a welcome page through
docs/README.md
or just redirect to the index of languageen
as default page if needed.Config
Expect
Now
The text was updated successfully, but these errors were encountered: