Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url-loader and assets with relative paths not starting with './' in MD files #310

Closed
x8x opened this issue Apr 30, 2018 · 2 comments
Closed
Labels
contribution welcome Contributions welcome type: enhancement Request to enhance an existing feature

Comments

@x8x
Copy link
Contributor

x8x commented Apr 30, 2018

Although it's probably better to use relative path starting with ./ (./images/image.png instead of images/image.png ) for assets, that is more a JS import requirement. In MD files it should be perfectly fine to use images/image.png, but in this case url-loader will not include image.png into assets.
Thinking about people switching to VuePress, could url-loader be made a little more flexible and allow both cases?

@ulivz ulivz added type: enhancement Request to enhance an existing feature contribution welcome Contributions welcome labels Apr 30, 2018
@ulivz
Copy link
Member

ulivz commented Aug 20, 2018

I just checked current VuePress and cannot reproduced it.


We're closing this issue as stale as it's more than 20 days without activity, and without an associated Pull Request. Please feel free to continue discussion. We'll reopen this issue if anything actionable is posted.

@ulivz ulivz closed this as completed Aug 20, 2018
@calin-darie-evo-sapio
Copy link

It's reproducible with Vuepress 1.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome type: enhancement Request to enhance an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants