-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($theme-default): close dropdown on mouseout (fix #2227) #2303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR cause you can not open |
Reproduced on my dad's iPhone, sorry for that because I don't have an iPhone iPad or Mac, so I did not test it on safari. It seems that safari has it's different way to deal with |
I searched some forum and docs, and since safari has it's own behavior, it will be unpossible to solve this problem with css. I will fix it by adding some listeners and functions to solve this problem. |
@acgotaku Oops, Nice Catch. |
@newsbielt703 @Mister-Hope Thanks for your reply! |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)