Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($cli): inferUserDocsDirectory ignore all node_modules #2137

Merged
merged 1 commit into from
Jan 16, 2020
Merged

fix($cli): inferUserDocsDirectory ignore all node_modules #2137

merged 1 commit into from
Jan 16, 2020

Conversation

cuijing1031
Copy link
Contributor

Ignore node_modules in multi-layer catalogue in inferUserDocsDirectory

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
inferUserDocsDirectory There is a pattern to ignore node_modules for globby in inferUserDocsDirectory function in vuepress/lib/handleUnknowCommand.js. But if there is a folder which has node_modules, it don't work. ' !/node_modules/' will work for this case. There is a demo for this case: https://github.com/cuijing1031/globby-demo.git

Ignore node_modules in multi-layer catalogue in inferUserDocsDirectory
Copy link
Member

@meteorlxy meteorlxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meteorlxy meteorlxy changed the title fix($vuepress): inferUserDocsDirectory ignore all node_modules fix($cli): inferUserDocsDirectory ignore all node_modules Jan 16, 2020
@meteorlxy meteorlxy merged commit df59909 into vuejs:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants