fix: fail to test specific package #2099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
yarn test
will run every tests in all workspaces.When I looked at the source code, I found that there's an option to test a specific package:
But when I ran
yarn test -p core
, it failed withReferenceError: core is not defined
.I tracked down
createJestRunner
and found it is caused by #1404.The
rawArgs
is supposed to contain'--inspect-brk'
, but it will also contain'-p'
and'core'
if I runyarn test --inspect-brk -p core
:Since
rawArgs
has been processed properly inscripts/test.js
:I add a argument - rawArgs to
createJestRunner
. It also make it a bit more reusable.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: