Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($plugin-pwa): no global-ui-component when updatePopup is disabled #2041

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

meteorlxy
Copy link
Member

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Other information:

Disable updatePopup in config.js:

['@vuepress/pwa', {
  updatePopup: false
}],

Before

index.html that generated by build:

<div class="global-ui"><!----><SWUpdatePopup></SWUpdatePopup></div>

After

index.html that generated by build:

<div class="global-ui"><!----></div>

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit 6f9e478 into vuejs:master Nov 29, 2019
@meteorlxy meteorlxy deleted the fix/pwa-component branch November 29, 2019 02:56
@vue-bot
Copy link

vue-bot commented Nov 29, 2019

Hey @meteorlxy, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants