-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat($theme-default): external links in prev/next (close #1962) #1984
feat($theme-default): external links in prev/next (close #1962) #1984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ludanxer, just a few changes to make and it will be ok
Co-Authored-By: Franck Abgrall <[email protected]>
Co-Authored-By: Franck Abgrall <[email protected]>
Hi @kefranabg , Thanks for your tips, really learned a lot since I participated in Vuepress. When it is an external link, |
@ludanxer I just made a test and For example:
|
Oh, right! Sorry, forget to take this scenario into consideration. |
@meteorlxy Could you help review again? BTW, I felt that it's difficult to maintain continuously since we don't have unit tests for UI components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding a <OutboundLink />
?
Co-Authored-By: meteorlxy <[email protected]>
Co-Authored-By: meteorlxy <[email protected]>
@meteorlxy Thanks for the review. I didn't add But you are right, they need to be consistent. |
Hey @ludanxer, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Howdy, is there a version with this available? Many thanks. |
@mbana Not yet. It will be available in version 1.3.0 |
@meteorlxy, I am afraid I can't see that on https://www.npmjs.com/package/vuepress?activeTab=versions. |
😅 It "will" be. Has not released yet |
Summary
fix #1962
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: