feat($plugin-search): Add support for search hotkeys #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaera
changed the title
kefranabg
changed the title
kefranabg
approved these changes
Sep 10, 2019
|
Hello thank's for your work ! Can please add the event on function and destroy the event on the lifecycle beforeDestroy please |
flozero
reviewed
Sep 10, 2019
flozero
added
need feedback
|
@f3ltron Yes, it's been updated. |
flozero
approved these changes
Sep 11, 2019
kefranabg
approved these changes
Sep 12, 2019
|
Hey @evaera, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds hotkey to focus SearchBox component with configurable keys, defaulting to
sand/.This makes it much easier to switch to the docs and focus the searchbox when using documentation in tandem with programming. Sites like docs.rs and even GitHub itself support this behavior.
Fixes #624
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes: