Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): optimize error log (close: #1296) #1413

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Mar 7, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Old non-string request resolution

Try to resolve the request as absolute/relative/dependency path and import them in chain. Use the first result as the resolved module. If any error was encounted, respective resolution will be skipped.

What are the drawbacks?

This PR's implementation

Try to resolve the request as absolute/relative/dependency path in chain.

  • If an entry file was found, vuepress will some the try-chain and try to load the file.
  • If the entry file is successfully loaded, apply it as a plugin/theme.
  • If an error was encounted, vuepress will leave a error log en error was encounted in plugin "xxx".
  • If all possible files do not exist, vuepress will leave a error log cannot resolve plugin "xxx".
  • If similar problem was encounted in theme entry file resolution, the error log will replace plugin with theme.

@shigma shigma requested a review from ulivz March 7, 2019 13:18
@shigma shigma changed the title fix($core): refine error log (close: #1296) fix($core): optimize error log (close: #1296) Mar 7, 2019
@flozero
Copy link
Collaborator

flozero commented Sep 5, 2019

I like definitely this PR

@flozero flozero added complexity: medium Medium complexity status: core team assigned Core team member assigned topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress labels Sep 5, 2019
@ulivz ulivz merged commit 51de6cf into master Sep 23, 2019
@vue-bot
Copy link

vue-bot commented Sep 23, 2019

Hey @shigma, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium Medium complexity status: core team assigned Core team member assigned topic: config Relates to VuePress config type: enhancement Request to enhance an existing feature version: 1.x Relates to version 1 of VuePress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants