Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish source code for vuepress-html-webpack-plugin or unfork it #1303

Closed
1 task done
benmccann opened this issue Feb 16, 2019 · 2 comments
Closed
1 task done

Publish source code for vuepress-html-webpack-plugin or unfork it #1303

benmccann opened this issue Feb 16, 2019 · 2 comments
Labels
type: question or discussion Question or discussion

Comments

@benmccann
Copy link

  • I confirm that this is a issue rather than a question.

Bug report

vuepress uses a fork 4816bef of html-webpack-plugin. This package was published to npm, but the source code never made available. This means I can't understand what the issue was that was being worked around that made the fork required

Version

master

Steps to reproduce

  1. Look for source code of vuepress-html-webpack-plugin
  2. Fail to find it anywhere on the internet

What is expected?

It should be a repo under https://github.com/vuejs with a clear explanation as to why the package had to be forked and what was changed

Or even better, the dependency on this closed source package should be removed and the project should switch back to the upstream html-webpack-plugin unforking the code

What is actually happening?

The package was published to npm, but the source code was never made available

Other relevant information

  • Your OS: any
  • Node.js version: any
  • Browser version: any
  • Is this a global or local install? either
  • Which package manager did you use for the install? any
@olizilla
Copy link

olizilla commented Oct 14, 2019

I suspect these are the sources you are looking for https://github.com/yyx990803/html-webpack-plugin

nope it appears not.

Ah ha, it's just to rename the module

This is published as vuepress-html-webpack-plugin to be used in VuePress. This is to fix a situation when the user installs a version of html-webpack-plugin that is compatible with VuePress' (which causes it to be hoisted to node_modules root) but also with a version of webpack that is incompatible. Because html-webpack-plugin directly make requires into webpack internals, it ends up requiring the internal modules from the incompatible version of webpack.

jantimon/html-webpack-plugin@master...yyx990803:master#diff-04c6e90faac2675aa89e2176d2eec7d8R3

@benmccann
Copy link
Author

Thanks for the answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question or discussion Question or discussion
Projects
None yet
Development

No branches or pull requests

3 participants