Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix #1011 anchor links not updating current URL #1014

Merged
merged 1 commit into from
Nov 17, 2018
Merged

🐛 Fix #1011 anchor links not updating current URL #1014

merged 1 commit into from
Nov 17, 2018

Conversation

dcastil
Copy link
Contributor

@dcastil dcastil commented Nov 16, 2018

Summary

closes #1011

The URL doesn't update because of e.preventDefault() called in an event listener attached to all anchor links. My fix updates the displayed URL to reflect the change but doesn't break the smooth scroll to the anchor tag (which is why e.preventDefault() is being called in the first place).

Note: The smooth scrolling doesn't work in Safari, it just jumps to the anchor tag immediately. My PR doesn't change that behaviour.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ulivz ulivz merged commit 1a87017 into vuejs:master Nov 17, 2018
@dcastil dcastil deleted the bugfix/anchor-links-dont-update-url branch November 17, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header anchor link clicks don't change current URL
2 participants