custom serializer causes Maximum call stack size exceeded error if the document contains a reference firestore.DocumentSnapshot

[wujekbogdan]

Reproduction

Define a serializer that returns an object containing a reference to firestore.DocumentSnapshot

bindFirestoreRef('boundRef', ref, {
  maxRefDepth : 0,
  serialize: (snap) => ({
    ...snap.data(),
    id: snap.id,
    snap,
  }),
});

Expected behavior

I would expect maxRefDepth : 0 to prevent vuexfire from binding nested document snapshots

Actual behavior

I'm getting Uncaught RangeError: Maximum call stack size exceeded

Additional information

I found a workaround:

bindFirestoreRef('boundRef', ref, {
  serialize: (snap) =>
    Object.defineProperty(
      {
        ...snap.data(),
        id: snap.id,
      },
      'snap',
      {
        configurable: false,
        value: snap,
      }
    ),
});

[wujekbogdan]

It turned out that I wasn't a bug in vuexfire. It was a bug in Firebase (firebase/firebase-js-sdk#4258) that's fixed in the 8.2.5 release.