-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): make VNodeChildrenArrayContents type more accurate #7287
Conversation
@@ -3,9 +3,7 @@ import { Vue } from "./vue"; | |||
export type ScopedSlot = (props: any) => VNodeChildrenArrayContents | string; | |||
|
|||
export type VNodeChildren = VNodeChildrenArrayContents | [ScopedSlot] | string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder where is [ScopedSlot]
used. VNodeChildren is used in createElement function. But it seems scopedSlots should be defined in another argument rather than VNodeChildren. https://vuejs.org/v2/guide/render-function.html#createElement-Arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
VNodeChildren
withVNodeChildrenArrayContents
in its recursive declaration. The currentVNodeChildrenArrayContents
type looks inaccurate because it can include a scoped slot in the returned value of another scoped slot.VNodeChildrenArrayContents
inheritsArray
interface so that we can narrow the type withArray.isArray
function.