Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): make VNodeChildrenArrayContents type more accurate #7287

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Dec 20, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

  • Replaced VNodeChildren with VNodeChildrenArrayContents in its recursive declaration. The current VNodeChildrenArrayContents type looks inaccurate because it can include a scoped slot in the returned value of another scoped slot.
  • VNodeChildrenArrayContents inherits Array interface so that we can narrow the type with Array.isArray function.

@@ -3,9 +3,7 @@ import { Vue } from "./vue";
export type ScopedSlot = (props: any) => VNodeChildrenArrayContents | string;

export type VNodeChildren = VNodeChildrenArrayContents | [ScopedSlot] | string;
Copy link
Member

@HerringtonDarkholme HerringtonDarkholme Dec 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where is [ScopedSlot] used. VNodeChildren is used in createElement function. But it seems scopedSlots should be defined in another argument rather than VNodeChildren. https://vuejs.org/v2/guide/render-function.html#createElement-Arguments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yyx990803 yyx990803 merged commit 49aae6b into vuejs:dev Dec 20, 2017
@ktsn ktsn deleted the fix-vnode-children-type branch December 20, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants