Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not make an issue for this, but would be nice to have this implemented.
To avoid warnings when integrating web components within Vue (e.g. polymer, ionic 4 / stenciljs), we currently need to add them to ignoredElements.
I think it would be a nice addition if we would be able to use a wildcard there, for example:
Vue.config.ignoredElements = ['ion*']
instead of
Vue.config.ignoredElements = ['ion-app', 'ion-header', 'ion-page', 'ion-toolbar', etc....]
All tests pass:
If there are better ways to implement this functionality (e.g. regex), let me know.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: