Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignored elements wildcard #6769

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

raymondmuller
Copy link
Contributor

Did not make an issue for this, but would be nice to have this implemented.
To avoid warnings when integrating web components within Vue (e.g. polymer, ionic 4 / stenciljs), we currently need to add them to ignoredElements.
I think it would be a nice addition if we would be able to use a wildcard there, for example:

Vue.config.ignoredElements = ['ion*']

instead of

Vue.config.ignoredElements = ['ion-app', 'ion-header', 'ion-page', 'ion-toolbar', etc....]

All tests pass:

86 specs, 0 failures
Finished in 0.698 seconds

If there are better ways to implement this functionality (e.g. regex), let me know.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yyx990803 yyx990803 merged commit 795b908 into vuejs:dev Oct 12, 2017
@yyx990803
Copy link
Member

I like the idea, but I think it's more flexible to just allow using regexp in the option, so I made some changes. Thanks for the PR!

ztlevi pushed a commit to ztlevi/vue that referenced this pull request Feb 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants