Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: have the bundle.js generated for SSR on the server #11598

Conversation

RossComputerGuy
Copy link

@RossComputerGuy RossComputerGuy commented Aug 15, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Couldn't find the original issue but this fixes the problem of the server side webpack bundle.js not being generated. I made the fix based on how the comment was made so it's a relatively simple fix.

@posva
Copy link
Member

posva commented Aug 15, 2020

Can you please provide a reproduction?

@RossComputerGuy
Copy link
Author

When trying to build my website, https://github.com/emberliteOS/website/, only the client bundle js is generated and not the server's. This PR should fix that.

@posva
Copy link
Member

posva commented Aug 15, 2020

But a boiled down reproduction we can take a look at. Or a test that failed before (not sure if this one is feasible that way)

@posva
Copy link
Member

posva commented Sep 21, 2020

Closing due to inactivity. Please open a new issue with a reference to this one if you can follow up with more information.

@posva posva closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants