-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prop changes do not always trigger $watch in IE11 #7915
Comments
it's indeed skipping some callbacks. Not sure if this is easily fixable without breaking something else 🤔 |
@posva I'm actually able to reproduce the skipped events even in Chrome if I turn on 6x slowdown CPU throttling. Practically though this is mainly a problem in IE11 because falling back to With 2.4.2: With 2.5.16 I'm happy to submit a PR once we have an idea of how we want to solve this. I actually wonder if 844a540 is just paving over a more fundamental problem |
@posva @yyx990803 and thoughts on how we want to approach this? I'm eager to start working on a PR because this is severely impacting my application |
I'm sorry, it's not something I know how to help you with 😞 |
@posva what needs to be done in order to move this forward? |
@yyx990803 what needs to be done here? I'm more than happy to contribute |
I had a similar case on chrome when loading images (dont remember about other browsers) month or so ago on vue 2.5. Images had a loader while they're being read from file, but the images would not be loaded as long as youre scrolling the page (so if you keep scrolling up and down without a stop, the loaders would never disappear). Sadly didnt have much time to dig deeper, but I thought that it's just one of thoses "it's javascript" situations. The image loading was initiated within setTimeout so I'm guessing it's part of the reason. Could try reproducing it again maybe. |
It’s likely to be reverted in 2.6 according to discussion under several related issues. |
@Justineo is there a specific issue tracking that discussion? Also could we label this with "nextTick related" label to make sure it is considered alongside the other nextTick issues? |
This is really hurting my app - we have a Are there any updates on the status of the 2.6 discussion regarding the $nextTick debacle? There seems to be some radio silence. Can this please labeled with |
Does changing |
Looks like #8450 will fix this |
Version
2.5.16
Reproduction link
https://jsfiddle.net/50wL7mdz/242700/
Steps to reproduce
Open JSFiddle in IE11, and scroll the scrollbar up and down rapidly. Observe the console warns that occur when a prop update was missed
What is expected?
The
$watch
should be fired for every scroll eventWhat is actually happening?
Vue is handling subsequent scroll events before the watch is firing. In my use case we are integrating with another system, and it is important that we don't skip events.
This change is reproducible in versions >= 2.4.3 (you can change the version to 2.4.2 in the reproducer to see the correct behavior). Looking at the change log, it seems like this commit is a likely culprit.
The text was updated successfully, but these errors were encountered: