fix(ref): preserve ref on components after removing root element (#6718)

fix #6632, #6641
vuejs · Oct 3, 2017 · 6ad44e1 · 6ad44e1
1 parent baabd6d
commit 6ad44e1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js
@@ -697,6 +697,8 @@ export function createPatchFunction (backend) {
                   insert.fns[i]()
                 }
               }
+            } else {
+              registerRef(ancestor)
             }
             ancestor = ancestor.parent
           }

diff --git a/test/unit/features/ref.spec.js b/test/unit/features/ref.spec.js
@@ -196,15 +196,25 @@ describe('ref', () => {
     }
   })
 
-  it('should register on component with empty roots', () => {
+  it('should register on component with empty roots', done => {
     const vm = new Vue({
       template: '<child ref="test"></child>',
       components: {
         child: {
-          template: '<div v-if="false"></div>'
+          template: '<div v-if="show"></div>',
+          data () {
+            return { show: false }
+          }
         }
       }
     }).$mount()
     expect(vm.$refs.test).toBe(vm.$children[0])
+    vm.$refs.test.show = true
+    waitForUpdate(() => {
+      expect(vm.$refs.test).toBe(vm.$children[0])
+      vm.$refs.test.show = false
+    }).then(() => {
+      expect(vm.$refs.test).toBe(vm.$children[0])
+    }).then(done)
   })
 })