From 771075fd64757bba06dee7a75aa839472a09cc52 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 21:27:42 -0800
Subject: [PATCH 1/8] test: ensure Wrapper.setChecked() is a no-op for checked
 checkboxes

---
 test/specs/wrapper/setChecked.spec.js | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/test/specs/wrapper/setChecked.spec.js b/test/specs/wrapper/setChecked.spec.js
index 571a218f5..33c1d9592 100644
--- a/test/specs/wrapper/setChecked.spec.js
+++ b/test/specs/wrapper/setChecked.spec.js
@@ -55,6 +55,28 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(wrapper.find('.counter').text()).to.equal('4')
   })
 
+  it('should trigger a change event when called on a checkbox', () => {
+    const listeners = { change: sinon.spy() }
+    const input = mountingMethod({
+      template: `<input type="checkbox" v-on="$listeners">`,
+    }, { listeners })
+
+    input.setChecked()
+
+    expect(listeners.change).to.have.been.called
+  });
+
+  it('should not trigger a change event if the checkbox is already checked', () => {
+    const listeners = { change: sinon.spy() }
+    const input = mountingMethod({
+      template: `<input type="checkbox" checked v-on="$listeners">`,
+    }, { listeners })
+
+    input.setChecked()
+
+    expect(listeners.change).not.to.have.been.called
+  });
+
   it('updates dom with radio v-model', async () => {
     const wrapper = mountingMethod(ComponentWithInput)
 
@@ -67,7 +89,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(wrapper.text()).to.contain('radioFooResult')
   })
 
-  it('changes state the right amount of times with checkbox v-model', async () => {
+  it('changes state the right amount of times with radio v-model', async () => {
     const wrapper = mountingMethod(ComponentWithInput)
     const radioBar = wrapper.find('#radioBar')
     const radioFoo = wrapper.find('#radioFoo')

From 1ee1fa04f80fb797a5f3b4717c5ea19fa29c34b1 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 21:38:27 -0800
Subject: [PATCH 2/8] test: ensure Wrapper.setChecked() is a no-op for selected
 radios

Selecting already-selected radio buttons or checking already-checked
checkboxes should not trigger events.
---
 test/specs/wrapper/setChecked.spec.js | 38 +++++++++++++++++++++------
 1 file changed, 30 insertions(+), 8 deletions(-)

diff --git a/test/specs/wrapper/setChecked.spec.js b/test/specs/wrapper/setChecked.spec.js
index 33c1d9592..a6f536205 100644
--- a/test/specs/wrapper/setChecked.spec.js
+++ b/test/specs/wrapper/setChecked.spec.js
@@ -57,22 +57,22 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
 
   it('should trigger a change event when called on a checkbox', () => {
     const listeners = { change: sinon.spy() }
-    const input = mountingMethod({
-      template: `<input type="checkbox" v-on="$listeners">`,
-    }, { listeners })
 
-    input.setChecked()
+    mountingMethod(
+      { template: `<input type="checkbox" v-on="$listeners">` },
+      { listeners },
+    ).setChecked()
 
     expect(listeners.change).to.have.been.called
   });
 
   it('should not trigger a change event if the checkbox is already checked', () => {
     const listeners = { change: sinon.spy() }
-    const input = mountingMethod({
-      template: `<input type="checkbox" checked v-on="$listeners">`,
-    }, { listeners })
 
-    input.setChecked()
+    mountingMethod(
+      { template: `<input type="checkbox" checked v-on="$listeners">` },
+      { listeners },
+    ).setChecked()
 
     expect(listeners.change).not.to.have.been.called
   });
@@ -111,6 +111,28 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(wrapper.find('.counter').text()).to.equal('4')
   })
 
+  it('should trigger a change event when called on a radio button', () => {
+    const listeners = { change: sinon.spy() }
+
+    mountingMethod(
+      { template: `<input type="radio" v-on="$listeners">` },
+      { listeners },
+    ).setChecked()
+
+    expect(listeners.change).to.have.been.called
+  });
+
+  it('should not trigger a change event if the radio button is already selected', () => {
+    const listeners = { change: sinon.spy() }
+
+    mountingMethod(
+      { template: `<input type="radio" checked v-on="$listeners">` },
+      { listeners },
+    ).setChecked()
+
+    expect(listeners.change).not.to.have.been.called
+  });
+
   it('throws error if checked param is not boolean', () => {
     const message = 'wrapper.setChecked() must be passed a boolean'
     const wrapper = mountingMethod(ComponentWithInput)

From 562bf11676f2d57f3272e9554fbf38ac7010a453 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 21:54:44 -0800
Subject: [PATCH 3/8] fix: ensure Wrapper.setChecked() idempotence

---
 packages/test-utils/src/wrapper.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/packages/test-utils/src/wrapper.js b/packages/test-utils/src/wrapper.js
index 4810e75da..866347e40 100644
--- a/packages/test-utils/src/wrapper.js
+++ b/packages/test-utils/src/wrapper.js
@@ -375,6 +375,10 @@ export default class Wrapper implements BaseWrapper {
         )
       }
 
+      if (this.element.checked === checked) {
+        return
+      }
+
       if (event !== 'click' || isPhantomJS) {
         // $FlowIgnore
         this.element.selected = true

From f63eda294b30f25a223b9e50dca0bf782df6ef79 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 22:28:30 -0800
Subject: [PATCH 4/8] test: fix Wrapper.setChecked() test compatibility

Older versions of Vue use the `click` DOM event for updating
radio/checkbox `v-model`s.
---
 test/specs/wrapper/setChecked.spec.js | 102 ++++++++++++++++----------
 1 file changed, 65 insertions(+), 37 deletions(-)

diff --git a/test/specs/wrapper/setChecked.spec.js b/test/specs/wrapper/setChecked.spec.js
index a6f536205..ec5c9a344 100644
--- a/test/specs/wrapper/setChecked.spec.js
+++ b/test/specs/wrapper/setChecked.spec.js
@@ -56,26 +56,41 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
   })
 
   it('should trigger a change event when called on a checkbox', () => {
-    const listeners = { change: sinon.spy() }
-
-    mountingMethod(
-      { template: `<input type="checkbox" v-on="$listeners">` },
-      { listeners },
-    ).setChecked()
-
-    expect(listeners.change).to.have.been.called
-  });
+    const listener = sinon.spy()
+
+    mountingMethod({
+      // For compatibility with earlier versions of Vue that use the `click`
+      // event for updating `v-model`.
+      template: `
+        <input
+          type="checkbox"
+          @change="listener"
+          @click="listener"
+        >
+      `,
+      methods: { listener },
+    }).setChecked()
+
+    expect(listener).to.have.been.called
+  })
 
   it('should not trigger a change event if the checkbox is already checked', () => {
-    const listeners = { change: sinon.spy() }
-
-    mountingMethod(
-      { template: `<input type="checkbox" checked v-on="$listeners">` },
-      { listeners },
-    ).setChecked()
-
-    expect(listeners.change).not.to.have.been.called
-  });
+    const listener = sinon.spy()
+
+    mountingMethod({
+      template: `
+        <input
+          type="checkbox"
+          checked
+          @change="listener"
+          @click="listener"
+        >
+      `,
+      methods: { listener },
+    }).setChecked()
+
+    expect(listener).not.to.have.been.called
+  })
 
   it('updates dom with radio v-model', async () => {
     const wrapper = mountingMethod(ComponentWithInput)
@@ -112,26 +127,39 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
   })
 
   it('should trigger a change event when called on a radio button', () => {
-    const listeners = { change: sinon.spy() }
-
-    mountingMethod(
-      { template: `<input type="radio" v-on="$listeners">` },
-      { listeners },
-    ).setChecked()
-
-    expect(listeners.change).to.have.been.called
-  });
-
-  it('should not trigger a change event if the radio button is already selected', () => {
-    const listeners = { change: sinon.spy() }
-
-    mountingMethod(
-      { template: `<input type="radio" checked v-on="$listeners">` },
-      { listeners },
-    ).setChecked()
+    const listener = sinon.spy()
+
+    mountingMethod({
+      template: `
+        <input
+          type="radio"
+          @change="listener"
+          @click="listener"
+        >
+      `,
+      methods: { listener },
+    }).setChecked()
+
+    expect(listener).to.have.been.called
+  })
 
-    expect(listeners.change).not.to.have.been.called
-  });
+  it('should not trigger a change event if the radio button is already checked', () => {
+    const listener = sinon.spy()
+
+    mountingMethod({
+      template: `
+        <input
+          type="radio"
+          checked
+          @change="listener"
+          @click="listener"
+        >
+      `,
+      methods: { listener },
+    }).setChecked()
+
+    expect(listener).not.to.have.been.called
+  })
 
   it('throws error if checked param is not boolean', () => {
     const message = 'wrapper.setChecked() must be passed a boolean'

From e229e372dc2d34086a0023bcdf7706011c82a18b Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 22:40:09 -0800
Subject: [PATCH 5/8] test: ensure Wrapper.setSelected() idempotency

---
 test/specs/wrapper/setSelected.spec.js | 32 ++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/test/specs/wrapper/setSelected.spec.js b/test/specs/wrapper/setSelected.spec.js
index 102c9336a..b19d0a8da 100644
--- a/test/specs/wrapper/setSelected.spec.js
+++ b/test/specs/wrapper/setSelected.spec.js
@@ -39,6 +39,38 @@ describeWithShallowAndMount('setSelected', mountingMethod => {
     expect(wrapper.text()).to.contain('selectA')
   })
 
+  it('should trigger a change event on the parent <select>', () => {
+    const change = sinon.spy()
+
+    mountingMethod({
+      template: `
+        <select @change="change">
+          <option />
+          <option value="foo" />
+        </select>
+      `,
+      methods: { change },
+    }).findAll('option').at(1).setSelected()
+
+    expect(change).to.have.been.called
+  });
+
+  it('should not trigger an event if already selected', () => {
+    const change = sinon.spy()
+
+    mountingMethod({
+      template: `
+        <select @change="change">
+          <option />
+          <option selected value="foo" />
+        </select>
+      `,
+      methods: { change },
+    }).findAll('option').at(1).setSelected()
+
+    expect(change).not.to.have.been.called
+  });
+
   it('throws error if element is not valid', () => {
     const message = 'wrapper.setSelected() cannot be called on this element'
 

From 90a7ea88cf15cf5c3454867899ce2ff4fce265c5 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 22:51:49 -0800
Subject: [PATCH 6/8] fix: ensure Wrapper.setSelected() idempotency

---
 packages/test-utils/src/wrapper.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/packages/test-utils/src/wrapper.js b/packages/test-utils/src/wrapper.js
index 866347e40..816ec1620 100644
--- a/packages/test-utils/src/wrapper.js
+++ b/packages/test-utils/src/wrapper.js
@@ -404,6 +404,10 @@ export default class Wrapper implements BaseWrapper {
     }
 
     if (tagName === 'OPTION') {
+      if (this.element.selected) {
+        return
+      }
+
       // $FlowIgnore
       this.element.selected = true
       // $FlowIgnore

From 8ec4bfcb817692fc10ba682e02c4dd0eb2669376 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpoppelen@gmail.com>
Date: Wed, 18 Dec 2019 22:57:53 -0800
Subject: [PATCH 7/8] style: fix linting errors

---
 test/specs/wrapper/setChecked.spec.js  |  8 ++++----
 test/specs/wrapper/setSelected.spec.js | 18 ++++++++++++------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/test/specs/wrapper/setChecked.spec.js b/test/specs/wrapper/setChecked.spec.js
index ec5c9a344..60b31f267 100644
--- a/test/specs/wrapper/setChecked.spec.js
+++ b/test/specs/wrapper/setChecked.spec.js
@@ -68,7 +68,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
           @click="listener"
         >
       `,
-      methods: { listener },
+      methods: { listener }
     }).setChecked()
 
     expect(listener).to.have.been.called
@@ -86,7 +86,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
           @click="listener"
         >
       `,
-      methods: { listener },
+      methods: { listener }
     }).setChecked()
 
     expect(listener).not.to.have.been.called
@@ -137,7 +137,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
           @click="listener"
         >
       `,
-      methods: { listener },
+      methods: { listener }
     }).setChecked()
 
     expect(listener).to.have.been.called
@@ -155,7 +155,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
           @click="listener"
         >
       `,
-      methods: { listener },
+      methods: { listener }
     }).setChecked()
 
     expect(listener).not.to.have.been.called
diff --git a/test/specs/wrapper/setSelected.spec.js b/test/specs/wrapper/setSelected.spec.js
index b19d0a8da..23cc754a1 100644
--- a/test/specs/wrapper/setSelected.spec.js
+++ b/test/specs/wrapper/setSelected.spec.js
@@ -49,11 +49,14 @@ describeWithShallowAndMount('setSelected', mountingMethod => {
           <option value="foo" />
         </select>
       `,
-      methods: { change },
-    }).findAll('option').at(1).setSelected()
+      methods: { change }
+    })
+      .findAll('option')
+      .at(1)
+      .setSelected()
 
     expect(change).to.have.been.called
-  });
+  })
 
   it('should not trigger an event if already selected', () => {
     const change = sinon.spy()
@@ -65,11 +68,14 @@ describeWithShallowAndMount('setSelected', mountingMethod => {
           <option selected value="foo" />
         </select>
       `,
-      methods: { change },
-    }).findAll('option').at(1).setSelected()
+      methods: { change }
+    })
+      .findAll('option')
+      .at(1)
+      .setSelected()
 
     expect(change).not.to.have.been.called
-  });
+  })
 
   it('throws error if element is not valid', () => {
     const message = 'wrapper.setSelected() cannot be called on this element'

From cdc0762d7b94eb7f001c124bb0c0115f01382c60 Mon Sep 17 00:00:00 2001
From: Victor van Poppelen <vvanpo@gmail.com>
Date: Wed, 18 Dec 2019 23:49:47 -0800
Subject: [PATCH 8/8] test: follow convention for scenario statements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Adrià Fontcuberta <afontcu@gmail.com>
---
 test/specs/wrapper/setChecked.spec.js  | 8 ++++----
 test/specs/wrapper/setSelected.spec.js | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/specs/wrapper/setChecked.spec.js b/test/specs/wrapper/setChecked.spec.js
index 60b31f267..4d31c0677 100644
--- a/test/specs/wrapper/setChecked.spec.js
+++ b/test/specs/wrapper/setChecked.spec.js
@@ -55,7 +55,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(wrapper.find('.counter').text()).to.equal('4')
   })
 
-  it('should trigger a change event when called on a checkbox', () => {
+  it('triggers a change event when called on a checkbox', () => {
     const listener = sinon.spy()
 
     mountingMethod({
@@ -74,7 +74,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(listener).to.have.been.called
   })
 
-  it('should not trigger a change event if the checkbox is already checked', () => {
+  it('does not trigger a change event if the checkbox is already checked', () => {
     const listener = sinon.spy()
 
     mountingMethod({
@@ -126,7 +126,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(wrapper.find('.counter').text()).to.equal('4')
   })
 
-  it('should trigger a change event when called on a radio button', () => {
+  it('triggers a change event when called on a radio button', () => {
     const listener = sinon.spy()
 
     mountingMethod({
@@ -143,7 +143,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
     expect(listener).to.have.been.called
   })
 
-  it('should not trigger a change event if the radio button is already checked', () => {
+  it('does not trigger a change event if the radio button is already checked', () => {
     const listener = sinon.spy()
 
     mountingMethod({
diff --git a/test/specs/wrapper/setSelected.spec.js b/test/specs/wrapper/setSelected.spec.js
index 23cc754a1..efcda4627 100644
--- a/test/specs/wrapper/setSelected.spec.js
+++ b/test/specs/wrapper/setSelected.spec.js
@@ -39,7 +39,7 @@ describeWithShallowAndMount('setSelected', mountingMethod => {
     expect(wrapper.text()).to.contain('selectA')
   })
 
-  it('should trigger a change event on the parent <select>', () => {
+  it('triggers a change event on the parent select', () => {
     const change = sinon.spy()
 
     mountingMethod({
@@ -58,7 +58,7 @@ describeWithShallowAndMount('setSelected', mountingMethod => {
     expect(change).to.have.been.called
   })
 
-  it('should not trigger an event if already selected', () => {
+  it('does not trigger an event if called on already selected option', () => {
     const change = sinon.spy()
 
     mountingMethod({