Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapper.setSelected() to work on select with optgroups #715

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Fix wrapper.setSelected() to work on select with optgroups #715

merged 3 commits into from
Jun 14, 2018

Conversation

martynling
Copy link
Contributor

wrapper.setSelected() does not work for a select that has optgroups

  • added test to confirm the issue
  • added code to fix

eddyerburgh
eddyerburgh requested changes Jun 14, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

The code changes are great, but you included the build files in the PR (easily done). Can you remove the files in packages/*/dist, then I'll merge.

@martynling
Copy link
Contributor Author

@eddyerburgh The build file changes have been removed from the PR.

eddyerburgh
eddyerburgh approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks 👍

I'll release a new version with the changes tonight

@eddyerburgh eddyerburgh merged commit dae0b1c into vuejs:dev Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martynling @eddyerburgh