Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapper.find() deprecation clarification #1769

Closed
hewIngram opened this issue Jan 12, 2021 · 2 comments · Fixed by #1770
Closed

wrapper.find() deprecation clarification #1769

hewIngram opened this issue Jan 12, 2021 · 2 comments · Fixed by #1770
Labels

Comments

@hewIngram
Copy link
Contributor

Hi all, I was confused by this given the deprecation warnings and wanted to make sure the docs are clear.

As I understand it (mostly from digging through the issues here especially #1498 and #1594) find and findAll are sticking around and we're adding findComponent and findAllComponents` for the specific case where we're finding by component.

If that's the case should we clarify the deprecation warning here to highlight that find is staying? Multiple members of my team read this as "find is being removed and replaced by findComponent".

Screenshot 2021-01-12 at 17 01 11

Affected documentation page: https://vue-test-utils.vuejs.org/api/wrapper/#find

Thanks! Happy to make a tiny PR clarifying

@afontcu
Copy link
Member

afontcu commented Jan 12, 2021

Hi! Thank you for opening up the issue.

The sentence states that find is only deprecated when trying to search for a Component, but I agree it could be more explicit. Happy to review a PR with a clarification 😃

@afontcu afontcu added the docs label Jan 12, 2021
@hewIngram
Copy link
Contributor Author

You're totally right the docs are definitely not wrong I just think it could be slightly clearer: #1770

Thanks @afontcu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants