fix(types): ensure that DeepReadonly handles Ref type properly (fix #4701) #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- without exposing internal properties.
LinusBorg
added
scope: types
🔨 p3-minor-bug
Size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, refs are handled like ordinary objects, and the
keyofiteration exposes the privateRefSymbolwhich can lead to problems when creating type declarations.Note: I wasn't sure how to write a test for this as it doesn't happen within the vue-next repo, only in a consuming library that creates a declaration file during buld.
fix #4701