fix(runtime-core): allow overriding properties other than props #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2021
HcySunYang
suggested changes
Feb 4, 2021
This is useful for testing, as Jest can't spy on an object without `hasOwnProperty`. VTU can add it, but this commit is needed first.
cexbrayat
force-pushed
the
fix/has-own-property
branch
from
f572133
to
d1e95bc
Compare
HcySunYang
approved these changes
Feb 4, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You currently can't add properties like
hasOwnPropertyto the proxied objects as the check usesinto verify if it is not a prop mutation.This is useful for testing, as Jest can't spy on an object without
hasOwnProperty.VTU can add it, but this commit is needed first.
Related vuejs/test-utils#310