New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): should trigger collection's write-function correctly on non-reactive keys #1992

Merged

yyx990803 merged 1 commit into vuejs:master from Picknight:picknight/fix-collectionHandler

Sep 15, 2020

Contributor

Picknight commented Aug 27, 2020

Fix the following case:

let map = new Map()
map.set = function(key) {
  console.log('trigger set')
  return Map.prototype.set.call(map, key)
}

let proxy = reactive(map)
proxy.set('k', 'foo')  // Nothing is printed


          fix(reactivity): should trigger collection's write-function correctly…

988a664

… on non-reactive keys

yyx990803 merged commit fcf9b2c into vuejs:master

Picknight deleted the picknight/fix-collectionHandler branch

September 15, 2020 06:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet