Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the behavior of transiton event in v3 is diffrent of v2. #1145

Closed
underfin opened this issue May 8, 2020 · 2 comments
Closed

the behavior of transiton event in v3 is diffrent of v2. #1145

underfin opened this issue May 8, 2020 · 2 comments

Comments

@underfin
Copy link
Member

underfin commented May 8, 2020

What problem does this feature solve?

In v2, Theonleave event be triggered before nextFrame event.
But in v3,Theonleave event be triggered after nextFrame.
As same as enter and beforeEnter.
And I don't find this change in rfc.

// v3 test
waitForUpdate(() => {
        expect(beforeLeaveSpy).toHaveBeenCalledWith(_el)
      }).thenWaitFor(nextFrame).then(() => {
        expect(onLeaveSpy).toHaveBeenCalledWith(_el)
      }).
// v2 test
waitForUpdate(() => {
        expect(beforeLeaveSpy).toHaveBeenCalledWith(_el)
        expect(onLeaveSpy).toHaveBeenCalledWith(_el)
      }).thenWaitFor(nextFrame).then(() => {
      })

What does the proposed API look like?

Maybe should keep the behavior with v2.

@underfin
Copy link
Member Author

underfin commented May 8, 2020

If it is need to fix.I will pull a pr.

@underfin
Copy link
Member Author

underfin commented May 9, 2020

I re-think this. Maybe this change is not break user upgarde v3.So can we just do this?

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants