Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue-loader wants babel-runtime@^5.8.0 #96

Closed
egoist opened this issue Dec 8, 2015 · 15 comments
Closed

Vue-loader wants babel-runtime@^5.8.0 #96

egoist opened this issue Dec 8, 2015 · 15 comments

Comments

@egoist
Copy link

egoist commented Dec 8, 2015

But I've used babel-runtime@6 in my project.

preview

@egoist
Copy link
Author

egoist commented Dec 8, 2015

Well, have to downgrade to 5.8.0 instead.

@egoist egoist closed this as completed Dec 8, 2015
@billcolumbia
Copy link

It still works even after throwing this error. It's because 5.x.x -> 6.x.x is a major version from vue-loaders specified peerDeps afaik.

@egoist
Copy link
Author

egoist commented Dec 8, 2015

@billcolumbia why vue-loader does not upgrade to 6.x.x?

@billcolumbia
Copy link

Not sure. @yyx990803 will probably update the dependencies as things like this pop up. Would likely need to test to make sure the new versions don't break others deps or this package first.

@yyx990803
Copy link
Member

This is an intended downgrade. Babel runtime 6.x has a few unresolved bugs that makes it impossible to use typeof and a few other features. Also, because all babel plugins still depend on runtime 5.x, using 6.x at top level causes every single plugin to download a separate copy of 5.x, which ends up with 100Mb+ wasted disk space and a slower startup time.

I've already talked with Babel core team members about this and will upgrade to runtime 6.x when these issues are resolved.

@billcolumbia
Copy link

Nice. Thanks for the info - just downgraded! @yyx990803!

@OEvgeny
Copy link

OEvgeny commented Dec 8, 2015

Good point, Evan!

@utopiaio
Copy link

utopiaio commented Dec 8, 2015

I don't know if this will be read or not (issue being closed n' all), but Babel version change should be reflected on the 'README.md' with minor explanation why Vue-loader is not using Babel 6 (for now)

@yyx990803
Copy link
Member

@Moe-Szyslak It is still using Babel 6, the downgrade is only for the babel-runtime peer dependency. Usage is the same.

@utopiaio
Copy link

utopiaio commented Dec 8, 2015

ok, got it

While I have this stage, I would like to say thank you for all your hard work!

@taoeffect
Copy link

Hey @yyx990803 was just wondering if there's any news on this? It doesn't seem to be a big deal, I'm just curious whether those issues you mentioned have been resolved, and if not then what's holding them up? Maybe there are some issues you could point folks to so whoever has free time can help out?

@yyx990803
Copy link
Member

@taoeffect the core issue is that all official babel 6 plugins still rely on [email protected] as a dependency because they were compiled using babel 5. It seems they are indeed trying to move to self-hosting with babel 6 though:

@hzoo
Copy link

hzoo commented May 3, 2016

FYI: finally merged babel/babel#3438 in 6.8.0

@duebbert
Copy link

duebbert commented May 4, 2016

Came here from this page: http://vuejs.github.io/vue-loader/start/tutorial.html
As far as I can see, vue-loader now requires babel-runtime 6?

@chrisfillmore
Copy link

chrisfillmore commented May 4, 2016

What a coincidence, I arrived from the very same page as @duebbert, and I get npm WARN EPEERINVALID [email protected] requires a peer of babel-runtime@^6.0.0 but none was installed.

If I do npm install babel-runtime, I get

npm WARN install Couldn't install optional dependency: Unsupported
myproj@ C:\path\to\vue_webpack\myproj
└── UNMET PEER DEPENDENCY [email protected]

I am a bit confused now about which version I should have.

edit
I'm still acclimating myself to npm. I was able to resolve this by manually editing package.json to use babel-runtime@^6.0.0. I had also mistakenly included babel-runtime under "dependencies". Clearing this out resolved my warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants