Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vue-create Presets to Target Github Enterprise #3384

Open
matsieftw opened this issue Jan 28, 2019 · 10 comments
Open

Allow vue-create Presets to Target Github Enterprise #3384

matsieftw opened this issue Jan 28, 2019 · 10 comments
Labels
feature request needs team repro We acknowledged your report and will soon try to reproduce it scope: cli

Comments

@matsieftw
Copy link

What problem does this feature solve?

My company uses github enterprise so the preset we want to target is not located on github.com, gitlab.com, or bitbucket.com.

I would like to be able to run the command vue create --preset <url to my company's private github instance> or some other mechanism to indicate the domain.

What does the proposed API look like?

vue create -preset <domain>/repo_name

@matsieftw
Copy link
Author

We are aware of and are using the workaround of having the generator repo pulled down locally, but this means that the user will need to manage their local repo in order to use the generator. By adding a way to set up the domain to use Github Enterprise, we can ensure developers are consistently using the same, most up-to-date version of the generator.

@natiz
Copy link

natiz commented Jun 10, 2019

+1

@haoqunjiang
Copy link
Member

I think it's already supported. Since this feature is built on top of download-git-repo, it's possible to use urls in the form of direct:ssh://[email protected]/group/projectname.git. There's also an example on the documentation page now:

# self-hosted repos
vue create --preset gitlab:my-gitlab-server.com:group/projectname --clone my-project
vue create --preset direct:ssh://[email protected]/group/projectname.git --clone my-project

@matsieftw
Copy link
Author

So far, that command has not worked for me. I'm not using Gitlab. I am using Github enterprise. Using the direct ssh method does not appear to work.

I get Failed fetching remote preset and Error: 'git clone' failed with status 128

@haoqunjiang
Copy link
Member

Is the --clone flag correctly added?
If so, it may be a bug in https://github.com/flipxfx/download-git-repo

@matsieftw
Copy link
Author

Yes. The clone flag is correctly added. This feature does not work.

@matsieftw
Copy link
Author

Can this ticket be re-opened since it wasn't actually fixed and was closed before any confirmation was made over whether it was fixed?

@haoqunjiang haoqunjiang reopened this Jun 13, 2019
@haoqunjiang haoqunjiang added the needs team repro We acknowledged your report and will soon try to reproduce it label Jun 13, 2019
@haoqunjiang
Copy link
Member

You should rather report it to download-git-repo, though.

@haoqunjiang
Copy link
Member

And I personally don't have access to a GitHub enterprise server, so there's much I can help you with.

@eliranmal
Copy link

eliranmal commented Jun 15, 2019

for whom it may concern: as a workaround, i created a dedicated CLI tool to ease the process of cloning templates/presets hosted on enterprise/private repositories and storing them locally.

@matsieftw @sodatea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request needs team repro We acknowledged your report and will soon try to reproduce it scope: cli
Projects
None yet
Development

No branches or pull requests

5 participants