Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Navigation Types #730

Closed
Hebilicious opened this issue Jun 6, 2022 · 1 comment
Closed

Incorrect Navigation Types #730

Hebilicious opened this issue Jun 6, 2022 · 1 comment
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@Hebilicious
Copy link

Describe the bug

For some un-explainable reason I see a mismatch between the navigation types in the distributed version of vitepress (1.0.0-alpha.1) and the current repository.

image

Reproduction

  • Install vitepress "version": "1.0.0-alpha.1"
  • Look at the default-theme.d.ts or the types in dist

Expected behavior

  export interface NavItemWithChildren {
    text?: string
    items: NavItemWithLink[]
  }

should be

  export interface NavItemWithChildren {
  text?: string
  items: NavItem[]
}

System Info

System:
    OS: macOS 11.5.2
    CPU: (8) arm64 Apple M1
    Memory: 106.59 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.9.0 - ~/.nvm/versions/node/v17.9.0/bin/node
    Yarn: 1.22.15 - ~/.nvm/versions/node/v17.9.0/bin/yarn
    npm: 8.5.5 - ~/.nvm/versions/node/v17.9.0/bin/npm
  Browsers:
    Chrome: 102.0.5005.61
    Safari: 14.1.2


### Additional context

_No response_

### Validations

- [X] Follow our [Code of Conduct](https://vuejs.org/about/coc.html)
- [X] Read the [docs](https://vitepress.vuejs.org).
- [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@Hebilicious Hebilicious added the bug: pending triage Maybe a bug, waiting for confirmation label Jun 6, 2022
@kecrily
Copy link
Contributor

kecrily commented Jun 6, 2022

fixed on #711

@brc-dd brc-dd closed this as completed Jun 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants