Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a base type for ThemeConfig instead of any #628

Closed
kiaking opened this issue May 19, 2022 · 0 comments · Fixed by #1339
Closed

Define a base type for ThemeConfig instead of any #628

kiaking opened this issue May 19, 2022 · 0 comments · Fixed by #1339
Labels
enhancement New feature or request
Milestone

Comments

@kiaking
Copy link
Member

kiaking commented May 19, 2022

Right now this break features like next and previous links with locales because the sidebar is supposed to be an array while it's supposed to be an object on locales but next and previous links do not support that format and TS is not picking up any problem.

If sidebar items is supposed to be defined outside of themeConfig, then move it out and expose it as a type. It can also be used inside locales in SiteData type

@kiaking kiaking added the enhancement New feature or request label May 23, 2022
@kiaking kiaking added this to the v1.0.0 milestone May 27, 2022
This was referenced Sep 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant