Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist\client\theme-default\config.d.ts is not getting bundled #483

Closed
3 tasks done
brc-dd opened this issue Jan 4, 2022 · 3 comments
Closed
3 tasks done

dist\client\theme-default\config.d.ts is not getting bundled #483

brc-dd opened this issue Jan 4, 2022 · 3 comments
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@brc-dd
Copy link
Member

brc-dd commented Jan 4, 2022

Describe the bug

There is no config.d.ts available here: https://cdn.jsdelivr.net/npm/[email protected]/dist/client/theme-default/

It is required by: https://cdn.jsdelivr.net/npm/[email protected]/types/index.d.ts (line 4)

Expected behavior

config.d.ts to be present in dist/client/theme-default/ so that we can reference DefaultTheme in .vitepress/config.ts.

Additional context

Something needs to be changed with api-extractor as tsc (first part of build-types-client script) is generating the files perfectly in dist/temp.

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@brc-dd brc-dd added the bug: pending triage Maybe a bug, waiting for confirmation label Jan 4, 2022
@brc-dd
Copy link
Member Author

brc-dd commented Jan 4, 2022

Just noticed that #465 will also fix this. #484 can be closed without merging if the former is merged.

@yyx990803
Copy link
Member

Thanks, #465 has been merged.

@brc-dd
Copy link
Member Author

brc-dd commented Jan 6, 2022

@yyx990803 theme.d.ts (the one at project root for vitepress/theme) is still not in package.json's files array. It isn't being bundled too.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants