Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales Dropdown isn't displayed in navBar #322

Closed
m4dz opened this issue Jun 21, 2021 · 2 comments
Closed

Locales Dropdown isn't displayed in navBar #322

m4dz opened this issue Jun 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@m4dz
Copy link
Contributor

m4dz commented Jun 21, 2021

Describe the bug
Following #50 and #91, locales and theme.locales stay empty, whatever has been defined in config.js.

To Reproduce
Steps to reproduce the behavior:

  1. add to config.js
    module.exports = {
      ...
      locales: {
        '/': { lang: 'en-US' },
        '/fr/': { lang: ' fr-FR' },
      },
      ...
      themeConfig: {
        ...
        locales: {
          '/': { label: 'English' },
          '/fr/' : { label: 'Français' },
        },
      },
    };
    

Expected behavior
Dropdown lang selected should be displayed.

System Info

  • vitepress version: 0.15.4
  • vite version: 2.3.7
  • Node version: v16.3.0
  • OS version: macOS 11.4
@m4dz m4dz added the bug: pending triage Maybe a bug, waiting for confirmation label Jun 21, 2021
@MartinMalinda
Copy link

This seems to be fixed by @m4dz and it could be closed? I encountered this issue but then I updated to a later version of vitepress and it's gone.

@kiaking
Copy link
Member

kiaking commented May 23, 2022

Seems like this is fixed 👍

@kiaking kiaking closed this as completed May 23, 2022
@kiaking kiaking added bug Something isn't working and removed bug: pending triage Maybe a bug, waiting for confirmation labels May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants