Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): remove label background of code-group tabs #2136

Merged
merged 1 commit into from
Mar 25, 2023
Merged

fix(theme): remove label background of code-group tabs #2136

merged 1 commit into from
Mar 25, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 25, 2023

If you set a semi-transparent color to it:

:root {
  --vp-code-block-bg: rgba(0,0,0,0.2);
}

The background overlaps:

image

This is because .vp-code-group .tabs already set the background color, where .vp-code-group .tabs label duplicated that.

@antfu antfu marked this pull request as ready for review March 25, 2023 18:09
@brc-dd brc-dd merged commit eac03f2 into main Mar 25, 2023
@brc-dd brc-dd deleted the fix/code-group-bg-style branch March 25, 2023 18:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brc-dd brc-dd brc-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antfu @brc-dd