Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): enhance readability of custom containers (#1824) #1989

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Feb 24, 2023

close #1824

Increase contrast of custom containers. I've removed dimmed background and updated the yellow color to be more "amber" in order to have better contrast. It's extremely hard to have single color that works for both light and dark mode (especially yellow), but I think this is good enough?

It's kinda visually breaking change, but... it looks good though 👀

Screenshot 2023-02-24 at 20 47 42

Screenshot 2023-02-24 at 20 47 47

@kiaking kiaking added enhancement theme Related to the theme labels Feb 24, 2023
@kiaking kiaking self-assigned this Feb 24, 2023
@kiaking
Copy link
Member Author

kiaking commented Feb 27, 2023

OK let's go with this one for now. On light mode, the contrast score is still not above "A". However:

  1. Sites like Tailwind also has similar score on light mode.

  2. If we need to further increase the contrast, I think it's not possible by using the same color for both light/dark mode but rather we must have different colors for them. That is going to limit some customisability so I would like to avoid it.

Because of the above reason, I think it's fair to start with current contrast. If we get more feedback that we should increase the contrast, then I guess we should simply have different color sets for light and dark mode.

@kiaking kiaking merged commit 472b6ec into main Feb 27, 2023
@kiaking kiaking deleted the 1824-more-readable-custom-container branch February 27, 2023 09:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme Related to the theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad contrast for Custom Containers on light theme
1 participant