Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): infer collapsible from collapsed #1865

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix(theme): infer collapsible from collapsed #1865

merged 1 commit into from
Jan 31, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jan 30, 2023

⚠️ BREAKING CHANGES AHEAD

  • change collapsible: true, collapsed: true to collapsed: true
  • change rest of collapsible: true to collapsed: false

closes #1418

@brc-dd brc-dd requested a review from kiaking January 30, 2023 12:18
@kiaking
Copy link
Member

kiaking commented Jan 31, 2023

@brc-dd 👍 👍 👍 I guess when merging, adding BREAKING CHANGE comment will generate Changelog with braking change notice 👀 Please go ahead and merge this when you're ready 🙌

@brc-dd
Copy link
Member Author

brc-dd commented Jan 31, 2023

Hi, where to put that breaking change? 😅 I tried these locally, none is working:

fix!(theme): ...
fix(theme)!: ...
BREAKING CHANGE: ...
BREAKING CHANGE: fix(theme): ...

@kiaking
Copy link
Member

kiaking commented Jan 31, 2023

Whaaat... those syntax should work... 🤔 Maybe we need to directly modify Changelog on release process?

@brc-dd
Copy link
Member Author

brc-dd commented Jan 31, 2023

Okay, we need to add it in footer 😅 https://github.com/conventional-changelog-archived-repos/conventional-changelog-angular/blob/master/convention.md

@brc-dd brc-dd merged commit dea6cfa into main Jan 31, 2023
@brc-dd brc-dd deleted the drop-collapsible branch January 31, 2023 06:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sidebar] infer collapsible from collapsed and drop the former
2 participants
@brc-dd @kiaking