Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): enable multi level sidebar nesting (#1360) #1835

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jan 23, 2023

close #1360
close #1361
close #1680

This is the follow-up from #1823.

It adds multi-level nested sidebar items up to 6 levels deep counting up from the root. It also adds the ability to set links to any items. This means now we can add a link to the item which has children.

In order to make the caret icon consistent, the root level collapse icon has changed to caret from plus/minus icon.

Screen Shot 2023-01-23 at 18 22 42

@kiaking kiaking added the enhancement New feature or request label Jan 23, 2023
@kiaking kiaking requested a review from brc-dd January 23, 2023 10:59
@kiaking kiaking self-assigned this Jan 23, 2023
Copy link
Member

@LittleSound LittleSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing your mind, six levels of sidebar nesting should be sufficient for my project.

@kiaking kiaking merged commit c35a1f0 into main Jan 24, 2023
@kiaking kiaking deleted the 1360-2nd-level-sidebar-collapse branch January 24, 2023 12:38
@nekomeowww
Copy link

I was busy in last several days, so I am sorry for not replying. Thank you for changing your mind.

@Zhengqbbb
Copy link
Contributor

Thx for changing your mind 🤗. The overall document structure is determined by the user, we can choose two levels, three levels or deeper level, anyway it can resolve my current issues !
Looking forward to it improvement on the documentation 🔥 Nicccce work

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for collapsible multi-level sidebar
5 participants