feat(theme): refine overall styles #1790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1049
Organize and refine entire styles toward a stable release. I'm hoping this would be the last big breaking change on CSS variables.
I've tested with Vite site and it worked without modifying Vite's themes, so I think this is fairly safe, but users who do heavy customization might encounter coloring issues.
CSS Variable adjustment
I wanted to pay extra attention to reducing CSS variables so that it's easier for users to tweak the stylings.
I've almost entirely eliminated the need for
.dark
scoping. 99% (maybe 90%...) of stuff should work only by adjusting branding colors and no.dark
override should be needed.Adjusted the tone
I needed to adjust the tone of the design a bit to make single color work on both light and dark modes. I went to several docs sites like Laravel and others and adjusted the overall theme to be a bit darker, cooler (add a little bit of blue), and slightly higher contrast.
Nav adjustment
VPNav
so that it fills the entire page width for easier Nav styling.@brc-dd Could you go through several random pages to see if I didn't break anything? I've tested with Vite sites, and everything seems to be working including sponsors and team sections.