We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VPMenuLink does not handle regex for activeMatch.
activeMatch
Please see this StackBlitz:
Dropdown Menu > Item A
Item A
Dropdown Menu
Next Page
The Item A in the Nav should be active on both pages.
System: OS: macOS 13.0.1 CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz Memory: 26.19 MB / 16.00 GB Shell: 5.8.1 - /bin/zsh Binaries: Node: 18.12.0 - ~/.config/nvm/versions/node/v18.12.0/bin/node Yarn: 1.22.19 - ~/.config/nvm/versions/node/v18.12.0/bin/yarn npm: 8.19.2 - ~/.config/nvm/versions/node/v18.12.0/bin/npm Browsers: Chrome: 108.0.5359.124 Safari: 16.1 npmPackages: vitepress: ^1.0.0-alpha.35 => 1.0.0-alpha.35
I think we should add the third parameter to the function isActive in the component VPMenuLink because it handles the regex.
isActive
VPMenuLink
vitepress/src/client/theme-default/components/VPMenuLink.vue
Line 16 in 01ac579
Just like VPNavBarMenuGroup:
VPNavBarMenuGroup
vitepress/src/client/theme-default/components/VPNavBarMenuGroup.vue
Line 21 in 01ac579
The text was updated successfully, but these errors were encountered:
0913e0f
No branches or pull requests
Describe the bug
VPMenuLink does not handle regex for
activeMatch
.Reproduction
Please see this StackBlitz:
Dropdown Menu > Item A
. TheItem A
of theDropdown Menu
is active.Next Page
to go to second page. TheItem A
of theDropdown Menu
is inactive.theExpected behavior
The
Item A
in the Nav should be active on both pages.System Info
Additional context
I think we should add the third parameter to the function
isActive
in the componentVPMenuLink
because it handles the regex.vitepress/src/client/theme-default/components/VPMenuLink.vue
Line 16 in 01ac579
Just like
VPNavBarMenuGroup
:vitepress/src/client/theme-default/components/VPNavBarMenuGroup.vue
Line 21 in 01ac579
Validations
The text was updated successfully, but these errors were encountered: