Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a pathname:// protocol to escape SPA #1719

Merged
merged 1 commit into from
Dec 21, 2022
Merged

feat: provide a pathname:// protocol to escape SPA #1719

merged 1 commit into from
Dec 21, 2022

Conversation

samestep
Copy link
Contributor

Resolves #1685 by providing the same solution Docusaurus has.

The new example in docs/guide/asset-handling.md exercises the change to src/node/markdown/plugins/link.ts. To exercise the change to src/client/theme-default/support/utils.ts, apply this diff and run pnpm run docs:

diff --git a/docs/.vitepress/config.ts b/docs/.vitepress/config.ts
index 53a7068..3e56e60 100644
--- a/docs/.vitepress/config.ts
+++ b/docs/.vitepress/config.ts
@@ -53,7 +53,9 @@ export default defineConfig({
 })
 
 function nav() {
+  const link = 'pathname:///pure.html'
   return [
+    { text: link, link },
     { text: 'Guide', link: '/guide/what-is-vitepress', activeMatch: '/guide/' },
     { text: 'Configs', link: '/config/introduction', activeMatch: '/config/' },
     {

@brc-dd brc-dd merged commit ae21a3a into vuejs:main Dec 21, 2022
@samestep samestep deleted the pathname-protocol branch December 21, 2022 03:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error when clicking link to public
2 participants