Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(a11y): add aria-hidden to line numbers wrapper #1675

Merged

Conversation

chenxsan
Copy link
Contributor

@chenxsan chenxsan commented Dec 7, 2022

It seems to be more reasonable to set aria-hidden to true for those line numbers.

@brc-dd brc-dd changed the title feat: add aria-hidden to line numbers wrapper perf(a11y): add aria-hidden to line numbers wrapper Dec 9, 2022
@brc-dd brc-dd merged commit 4c5a892 into vuejs:main Dec 9, 2022
@chenxsan chenxsan deleted the feature/add-aria-hidden-for-line-numbers branch December 9, 2022 12:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants