fix: align $title with vuepress (#158) #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiaking
changed the title
kiaking
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Oh OK cool. Yeah, by the way I also thought, if we were to always add page.title at build time, we should do the same for description (should always have site.description if page.description is undefined).
I agree this can be a bit tricky, and also, at the moment, both page.title and page.description is in sync, so I guess that't good.
Let's come back to making page.title to have the default value outside of this PR 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
@kiaking I tried to do the localized
pageData.titlechange but looks like it is more involved than I thought. I do not have the siteDataByRoute when pageData is created https://github.com/vuejs/vitepress/blob/master/src/node/markdownToVue.ts#L42I still think that it would be good that do it, but I'll leave this one to someone else to check.
The PR only fixes the bug and aligns $site with the docs and vuepress.