Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance switcher not working on the first click #1542

Closed
3 tasks done
zam157 opened this issue Oct 26, 2022 · 0 comments · Fixed by #1543
Closed
3 tasks done

Appearance switcher not working on the first click #1542

zam157 opened this issue Oct 26, 2022 · 0 comments · Fixed by #1543
Labels
bug Something isn't working theme Related to the theme

Comments

@zam157
Copy link
Contributor

zam157 commented Oct 26, 2022 •
edited
Loading

Describe the bug

My system is on dark mode. Refresh the vitepress doc (on dark mode by default) and click the appearance switcher, the color theme does not change. I have to click it twice then it works properly.

I think the bug should have appeared after #1498 merged. I'll try to make a PR to fix it.

Reproduction

Refresh the vitepress doc (on dark mode by default) and click the appearance switcher

Expected behavior

The color theme would change on the first click

System Info

- Browsers: Windows 11 - Edge 106, Android 12 - Chrome 106

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@zam157 zam157 added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 26, 2022
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Oct 26, 2022
@zam157 zam157 mentioned this issue Oct 26, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theme): use stored preference to be the value of userPreference zam157/vitepress
2 participants
@zam157 @brc-dd