Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable transitions on theme change #1446

Closed
brc-dd opened this issue Oct 8, 2022 · 0 comments · Fixed by #1447
Closed

Disable transitions on theme change #1446

brc-dd opened this issue Oct 8, 2022 · 0 comments · Fixed by #1447
Labels
enhancement New feature or request theme Related to the theme

Comments

@brc-dd
Copy link
Member

brc-dd commented Oct 8, 2022 •
edited
Loading

Currently, all the stuff has different transition durations, which looks weird when someone toggles light/dark theme. We should do something like this:

https://paco.me/writing/disable-theme-transitions
https://stackoverflow.com/a/16575811/11613622

Paco's solution is more optimized. Refer: https://stackoverflow.com/a/31862081/11613622
@brc-dd brc-dd added enhancement New feature or request theme Related to the theme labels Oct 8, 2022
@brc-dd brc-dd mentioned this issue Oct 8, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theme): disable transitions on theme toggle vuejs/vitepress
1 participant
@brc-dd